Priorities for upcoming GHC releases

MangoIV · September 17, 2024, 11:06am

Stack

`-fplugin` could not find module when using GHC 9.6

opened 03:46PM - 21 Sep 23 UTC

resolution: upstream issue

When trying to build a project using [polysemy-plugin](https://github.com/polyse…my-research/polysemy/tree/master/polysemy-plugin#readme) with GHC 9.6, the build fails with a strange error. As far as I can tell this is a Stack issue, with the build command not including the `package-db` and `package` flags. GHC 9.4.7 works as intended ### Steps to reproduce 1. Clone this repository which contains a minimal reproducible example: https://github.com/knightzmc/psymy 2. Run `stack build` 3. It should throw an error 4. Change the `resolver` to `lts-21.12` 5. Build again 6. It should work ### Expected Expected to build without errors or warnings. ### Actual The final stage of building throws an error ~~~text Installing library in /private/tmp/psymy/.stack-work/install/aarch64-osx/d648be467e8db3bbfce8aea3e8a40e40c2a4aa997e10a82332008572e1290566/9.6.2/lib/aarch64-osx-ghc-9.6.2/problematic-0.0.0.0-7Tqbt47XADvFA7jcxUQnZt Error: Cabal-simple_6HauvNHV_3.10.1.0_ghc-9.6.2: '/Users/alex/.ghcup/ghc/9.6.2/bin/ghc' exited with an error: <command line>: Could not find module ‘Polysemy.Plugin’ Use -v (or `:set -v` in ghci) to see a list of the files searched for. Completed 14 action(s). Error: [S-7282] Stack failed to execute the build plan. While executing the build plan, Stack encountered the error: [S-7011] While building package problematic-0.0.0.0 (scroll up to its section to see the error) using: /Users/alex/.stack/setup-exe-cache/aarch64-osx/Cabal-simple_6HauvNHV_3.10.1.0_ghc-9.6.2 --verbose=1 --builddir=.stack-work/dist/aarch64-osx/Cabal-3.10.1.0 register Process exited with code: ExitFailure 1 ~~~ ### Stack version ~~~text stack --version Version 2.11.1, Git revision d06506a16289c6b90e6ffc0dcc8be7f80487ac07 (dirty) aarch64 hpack-0.35.2 ~~~ ### Method of installation * Via GHCup * Also happens with Nix ### Platform MacOS Sonoma aarch64, also reproducible on Ubuntu 22.04.2 LTS x86_64

Cabal

github.com/haskell/cabal

`register` fails if `-fplugin=Foo` is used in `ghc-options:`

opened 09:40AM - 27 Oct 23 UTC

closed 06:59AM - 04 Nov 23 UTC

hamishmack

type: bug needs triage

With `ghc >=9.6` `--abi-hash` initialises plugins and will fail if a module in `…-fplugin=Foo`. ``` $ ghc-9.4.7 --abi-hash -fplugin=Foo 921dcb31e865da25523dc30d4957f9c4 $ ghc-9.6.3 --abi-hash -fplugin=Foo <command line>: Could not find module ‘Foo’ Use -v (or `:set -v` in ghci) to see a list of the files searched for. ``` This causes problems because the fix for #3633 removes the package DB from the arguments passed when calling `ghc --abi-hash`. The code is [here](https://github.com/haskell/cabal/blob/ac017649d8e56854898a5aea005dfd6a1e9a82df/Cabal/src/Distribution/Simple/GHC.hs#L2061-L2068): ``` vanillaArgs = -- Package DBs unnecessary, and break ghc-cabal. See #3633 -- BUT, put at least the global database so that 7.4 doesn't -- break. vanillaArgs0 { ghcOptPackageDBs = [GlobalPackageDB] , ghcOptPackages = mempty } ``` To reproduce this issue with `cabal-install` and `ghc` `9.6.3` in the path: ``` $ cat test.cabal cabal-version: 3.4 name: test version: 0.1.0.0 build-type: Simple library exposed-modules: MyLib build-depends: base, polysemy, polysemy-plugin ghc-options: -Wall -fplugin=Polysemy.Plugin hs-source-dirs: src default-language: Haskell2010 ``` ``` $ cat src/MyLib.hs module MyLib (someFunc) where someFunc :: IO () someFunc = putStrLn "someFunc" ``` ``` $ cabal v1-install . Resolving dependencies... Starting test-0.1.0.0 Building test-0.1.0.0 Failed to install test-0.1.0.0 Build log ( /Users/hamish/.cabal-devx/logs/ghc-9.6.3/test-0.1.0.0-2vHb5qpV3rnA1Gux1WyweH.log ): cabal: Entering directory '.' Configuring test-0.1.0.0... Preprocessing library for test-0.1.0.0.. Building library for test-0.1.0.0.. Installing library in /Users/hamish/.cabal-devx/lib/x86_64-osx-ghc-9.6.3/test-0.1.0.0-2vHb5qpV3rnA1Gux1WyweH Error: cabal: '/nix/store/9drimq6n088xzlpk56hc9k6zb7a46qch-ghc-9.6.3/bin/ghc' exited with an error: <command line>: Could not find module ‘Polysemy.Plugin’ Use -v (or `:set -v` in ghci) to see a list of the files searched for. cabal: Leaving directory '.' Error: cabal: Some packages failed to install: test-0.1.0.0-2vHb5qpV3rnA1Gux1WyweH failed during the final install step. The exception was: ExitFailure 1 ``` This problem does not seem to affect `cabal v2-build`, but it does break haskell.nix (https://github.com/input-output-hk/haskell.nix/issues/2096).

Nixpkgs

github.com/NixOS/nixpkgs

Build failure in Haskell libraries using -fplugin flag

opened 01:16AM - 08 Apr 24 UTC

Diamondy4

0.kind: bug 6.topic: haskell

### Describe the bug Build failure on `installPhase` on projects that use `-fpl…ugin=Some.Plugin.Module.Here` flag in library's `ghc-options`. Appeared after recent haskellPackages update that bumped default GHC to 9.6. `cabal build` inside `shellFor` shell still working. <details> <summary>Failure log</summary> ```bash Running phase: buildPhase Preprocessing library for example-0.1.0.0.. Building library for example-0.1.0.0.. [1 of 1] Compiling Lib ( lib/Lib.hs, dist/build/Lib.o, dist/build/Lib.dyn_o ) @nix { "action": "setPhase", "phase": "checkPhase" } Running phase: checkPhase Package has no test suites. @nix { "action": "setPhase", "phase": "haddockPhase" } Running phase: haddockPhase @nix { "action": "setPhase", "phase": "installPhase" } Running phase: installPhase Installing library in /nix/store/qcmqhpfphzlc7ww25dgqv1rksi3dlgy6-example-0.1.0.0/lib/ghc-9.6.4/lib/x86_64-linux-ghc-9.6.4/exa> Error: Setup: '/nix/store/p64ngk1v9d63lnrnyq0cynjd8jdk5jfa-ghc-9.6.4/bin/ghc' exited with an error: <command line>: Could not load module ‘GHC.TypeLits.Normalise’ It is a member of the hidden package ‘ghc-typelits-natnormalise-0.7.9’. Perhaps you need to add ‘ghc-typelits-natnormalise’ to the build-depends in your .cabal file. Use -v (or `:set -v` in ghci) to see a list of the files searched for. ``` </details> [Minimal failing example here](https://github.com/Diamondy4/nix-broken-ghc-plugin-example). [Same example but on pre-default GHC 9.6 nixpkgs commit](https://github.com/Diamondy4/nix-broken-ghc-plugin-example/tree/working-old-nix-ghc) builds successfully with default GHC 9.4. ### Steps To Reproduce Steps to reproduce the behavior: 1. Add any GHC plugin to library's build-depends 2. Add that GHC plugin to library's ghc-options as "-fplugin=Some.Plugin.Module.Here" 3. Build it ### Expected behavior Successful build as it was before recent haskell-updates merge (before default GHC 9.6) ### Additional context Tested with effectful-plugin and ghc-typelits-natnormalise. ### Notify maintainers  @NixOS/haskell @ncfavier @cdepillabout @expipiplus1 @maralorn @sternenseemann ### Metadata Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the result. ```console [user@system:~]$ nix-shell -p nix-info --run "nix-info -m" - system: `"x86_64-linux"` - host os: `Linux 6.8.4-cachyos, NixOS, 24.05 (Uakari), 24.05.20240403.fd281bd` - multi-user?: `yes` - sandbox: `yes` - version: `nix-env (Nix) 2.21.1` - nixpkgs: `/nix/store/n2g5cqwv8qf5p6vjxny6pg3blbdij12k-source` ``` --- Add a :+1: [reaction] to [issues you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [issues you find important]: https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

The fix is in 3.10.3